Ah, UCKeyTranslate, how I've missed you. :-) This looks like pretty standard dead-key handling code, and looks fine to me. One very small point and not worth sending another review: at line 672 672 // out = [jkeyCode, jkeyLocation]; I would add the testDeadChar to the end of the comment.
-- Scott K. On Sep 6, 2012, at 5:02 AM, Alexander Scherbatiy <[email protected]> wrote: > > bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7196547 > webrev: http://cr.openjdk.java.net/~alexsch/7196547/webrev.00/ > > The characters method from the NSEvent class returns an empty string for dead > keys. > The fix uses the UCKeyTranslate() method to know a dead key state from the > key code and key modifiers on the first step, > and dead key state and space key to know the dead key char actual value on > the second step. > > Thanks, > Alexandr. >
