In this case it would be good to check it in another CR. Fix itself looks good.

07.09.2012 23:55, Leonid Romanov wrote:
I dunno. I just did some cleanup of existing code, I didn't dig deeper. I'll investigate it.

On Sep 7, 2012, at 11:53 PM, Sergey Bylokhov <[email protected] <mailto:[email protected]>> wrote:

Hi, Leonid.
Why we cannot use javaExtMask everywhere in CMenuItem.java.setLabel(...) && CMenuItem.m ?

07.09.2012 22:41, Leonid Romanov wrote:
Hi,
Please review a fix for 7160951: [macosx] ActionListener called twice for JMenuItem using ScreenMenuBar. Although a number of files have been changed, only CMenuItem.m changes constitutes the fix, the rest of the changes is a bit of code cleanup.
The fix has been contributed by Marco Dinacci. Thanks!

Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7160951
Webrev: http://cr.openjdk.java.net/~leonidr/7160951/webrev.01/ <http://cr.openjdk.java.net/%7Eleonidr/7160951/webrev.01/>

Thanks,
Leonid.


--
Best regards, Sergey.



--
Best regards, Sergey.

Reply via email to