Hi Anthony,
Thanks for the review.
On 19.07.2013 17:43, Anthony Petrov wrote:
Hi Anton,
The fix looks good overall.
I'm just not sure about the exact symmetry between the setContent() method and the
componentRemoved() listener wrt. the layoutSizeListener adding/removing. In theory, the
setContent() may be called several times with different (or same) content objects. Similarly, the
contentPane may in theory be added or removed manually several times (or even transferred between
different JLFs).
setContent() is the API method which we don't control (and which indeed, in theory, may be called
several times with any content).
But the content pane is what we manage internally. It's tight to the JLF instance and follows its
life cycle. (Yes, a developer may hack it, but this is strongly discouraged =)
Perhaps both adding and removing the layoutSizeListener should happen in componentAdded() and
componentRemoved() correspondingly?
I like the idea. Here's the new version:
http://cr.openjdk.java.net/~ant/JDK-8020927/webrev.1
Thanks,
Anton.
--
best regards,
Anthony
On 07/19/2013 04:27 PM, Anton V. Tarasov wrote:
Please, review a fix.
jira: https://jbs.oracle.com/bugs/browse/JDK-8020927
webrev: http://cr.openjdk.java.net/~ant/JDK-8020927/webrev.0
Layout bounds notifications are added to internal JLightweightFrame API.
(Just FYI, related fx changes are here:
http://cr.openjdk.java.net/~ant/RT-30650/webrev.0)
Thanks,
Anton.
