Hello. This is a reminder. Could I please get the second review on this?
The bug: https://bugs.openjdk.java.net/browse/JDK-8024163 The fix: http://cr.openjdk.java.net/~pchelko/8024163/webrev.01 Thank you. With best regards. Petr. On Sep 25, 2013, at 3:05 PM, Petr Pchelko <[email protected]> wrote: > Hello, AWT Team. > > Please review the updated version of this fix. > It's available at: http://cr.openjdk.java.net/~pchelko/8024163/webrev.01/ > > I have changed the dragExit events generation a bit and added a couple of > tests. > > With best regards. Petr. > > On Sep 24, 2013, at 6:30 PM, Petr Pchelko <[email protected]> wrote: > >> Hello, AWT Team. >> >> Please review the fix for the following issue: >> https://bugs.openjdk.java.net/browse/JDK-8024163 >> The fix is available here: >> http://cr.openjdk.java.net/~pchelko/8024163/webrev.00/ >> >> The problem is with the DropTarget Enter/Exit events. For real heavyweights >> they are generated by native code. For lightweights - in shared code. But >> for AWT components they should be generated in CDropTargetContextPeer. >> Before the fix these events could be generated incorrectly: sometimes >> duplicated events were sent (this broke autoscrolling) and sometimes events >> were not sent at all - this caused NPEs in the shared code. >> The insideTarget boolean was replaced by a reference to DropTarget to handle >> nested components correctly. >> >> Tested on Mac OS X (no shared code affected). >> No new regression test failures. >> >> With best regards. Petr. >> >> >
