Please see my comment inline.
Anthony Petrov wrote:
Hi Christine,
src/share/classes/java/awt/event/InputEvent.java
- * <PRE>
+ * <PRE>{@code
The {@code} is redundant here because the <pre> tag forces the text to
use a fixed-size font already. Same comment for
src/share/classes/java/awt/font/LineBreakMeasurer.java.
Without {@code}, I will need to change & to & because it is an
error. I can simply change & to & then I don't need {@code
/hudson/jobs/jdk8-jdk-build-all/workspace/jdk/src/share/classes/java/awt/event/InputEvent.java:448:
error: bad HTML entity
* if ((event.getModifiersEx() & (onmask | offmask)) == onmask) {
^
In my Crucible code review, Joe suggested to use {@code} so we can leave
>, <, & unchanged.
src/share/classes/java/awt/event/MouseEvent.java
- * <code>Component</code>). Due to platform-dependent Drag&Drop
implementations,
+ * <code>Component</code>). Due to platform-dependent Drag&Drop
implementations,
Since you change this line anyway, I also suggest to replace <code>
with {@code} here. Same comment for
src/share/classes/java/awt/font/NumericShaper.java.
For NumericShaper.java, if I change <code>... </code> to {@code ... },
it introduces 2 errors. If I only change & to & then it is fine.
NumericShaper.java:1215: error: unterminated inline tag
* {@code if ((shaper.getRanges() & shaper.ARABIC) != 0) { ... }
^
NumericShaper.java:1214: error: element not closed: blockquote
* <blockquote>
^
Thanks
Christine
src/share/classes/java/awt/font/OpenType.java
- * ( <a
href=http://www.microsoft.com/typography/otspec/";>http://www.microsoft.com/typography/otspec/l</a>
).
+ * ( <a
href="http://www.microsoft.com/typography/otspec/";>http://www.microsoft.com/typography/otspec/l</a>
).
There's an extra 'l' character right before the closing </a>, which
needs to be removed.
--
best regards,
Anthony
On 10/08/2013 05:59 AM, [email protected] wrote:
Hi,
Please review a fix for
https://bugs.openjdk.java.net/browse/JDK-8026021
more fix of javadoc errors and warnings reported by doclint, see the
description
webrev: http://cr.openjdk.java.net/~cl/8026021/webrev.00/
Thanks
Christine
