Hello, Sergey.

> The fix looks good. But before the push, can you split "very long lines" and 
> replace:
> OSInfo.getOSType().name().toLowerCase().contains("mac")
> to
> OSInfo.getOSType() == OSInfo.OSType.MACOSX

Sure! Thank you for the review.

With best regards. Petr.

On 28.11.2013, at 18:14, Sergey Bylokhov <[email protected]> wrote:

> Hi, Petr.
> The fix looks good. But before the push, can you split "very long lines" and 
> replace:
> OSInfo.getOSType().name().toLowerCase().contains("mac")
> to
> OSInfo.getOSType() == OSInfo.OSType.MACOSX
> 
> 
> On 28.11.2013 16:25, Petr Pchelko wrote:
>> Hello, AWT Team.
>> 
>> Please review the fix for the issue:
>> https://bugs.openjdk.java.net/browse/JDK-7152982
>> The fix is available at:
>> http://cr.openjdk.java.net/~pchelko/7152982/webrev/
>> 
>> The fix adds AutoDelay to the robot. Also on Mac we are using unicode 
>> characters to specify the event modifiers. These characters were added to 
>> the test, so it now pass.
>> 
>> Thank you.
>> With best regards. Petr.
> 
> 
> -- 
> Best regards, Sergey.
> 

Reply via email to