Hi Petr,

The fix looks OK. A couple of remarks:

1.
1618                         // common practice (Wine, SWT) seems to be to

Is that Wine - the www.winehq.org ? Or is it a typo?

2. Does it make sense to compile two lists for the if/else statements: one before JDK-7075105, and the other one - the current one, and compare them to make sure this is the last regression of this kind?

--
best regards,
Anthony

On 12/06/2013 04:17 PM, Petr Pchelko wrote:
Hello, AWT Team.

Please review the fix for the issue:
https://bugs.openjdk.java.net/browse/JDK-8029565
The fix is available at:
http://cr.openjdk.java.net/~pchelko/8029565/webrev/

This is a yet another regression of the  JDK-7075105 and a yet another 
copy/paste fix.
I'm going to file a bug to perform a major refactoring of the DataTransferer 
code early in JDK 9 as now it's a mess.

With best regards. Petr.

Reply via email to