Hello, Anthony, Sergey. Thank you for the review. The new version could be found here: http://cr.openjdk.java.net/~pchelko/9/7159566/webrev.01/
I've fixed it according to your comments. With best regards. Petr. On 18.12.2013, at 18:03, Sergey Bylokhov <[email protected]> wrote: > Hi, Petr. > The fix looks good. I have 2 suggestions : > 1 LWChoicePeer.this prefix is unnecessary here? > 2 Can you add a small description about this code as a comment? > Thanks. > On 18.12.2013 13:54, Petr Pchelko wrote: >> Hello, AWT Team. >> >> Please review the fix for the issue: >> https://bugs.openjdk.java.net/browse/JDK-7159566 >> The fix is available at: >> http://cr.openjdk.java.net/~pchelko/9/7159566/webrev/ >> >> The problem: when showing the choice popup we need to use a choice as an >> invoker to process grab correctly. That's why we have the piece of code I'm >> fixing. >> However, we also need to set a correct location of the popup. A 'heavy' >> getLocationOnScreen is used because the choice might have already been moved >> by the >> window manager by this point to fit the screen and it's the only public way >> to get the location of the popup menu. >> >> The added test checks that there's no popup on the top of the window by >> clicking there. >> >> With best regards. Petr. > > > -- > Best regards, Sergey. >
