Hi Petr,
The fix looks good technically. However, I'm not sure if allowing apps
to use the Cmd-Space shortcut is a good idea because by default this key
combination is used to either switch between keyboard layouts, or
activate the SpotLight. So I think this line has been commented out
because of Human Interface Guidelines for OS X. I'm not 100% convinced
we should change that.
Are there other opinions? Mike, what do you think?
--
best regards,
Anthony
On 3/6/2014 1:00 PM, Petr Pchelko wrote:
Hello, AWT Team.
Please review a one-liner for:
https://bugs.openjdk.java.net/browse/JDK-8036757
The fix is available at:
http://cr.openjdk.java.net/~pchelko/9/8036757/webrev/
I supple this line was commented out because the code is not compilable with
it) We should return a
space character, it will be replaced with a proper ‘Space’ string internally by
Cocoa. In case the app
is bundled the string would even be localized. In non-bundled apps native
localization does not work,
but we can do nothing about it.
With best regards. Petr.
