Hello again. I’ve updated the fix. The new version is here: http://cr.openjdk.java.net/~pchelko/9/8030710/webrev.01/
1. I’ve modified the test so it now doesn’t need .html file, also copyright was added. 2. I’ve replaced the public.jpeg mime with a predefined kUTTypeJPEG (which is the same). No such constant in Cocoa, only in Carbon. With best regards. Petr. 06 марта 2014 г., в 2:56 после полудня, Petr Pchelko <[email protected]> написал(а): > Hello, Sergey. > >> I guess JFIF is not a typo in CDataTransferer? > Nop. http://en.wikipedia.org/wiki/JPEG_File_Interchange_Format > Also please see the macosx flavormap.properties type. We call a native as a > JFIF and it’s left as is because > it’s called like this on other platforms. > >> Do we really need ImageTransferTest.html in the test? > The test is for interprocess DnD, so we run the first process as an applet > from jtreg. > The applet then starts a second processes main(). I’ll check if I could use 2 > main() in one file and if it’s fine for jtreg. > >> Also copyright header is missing. > Thank you. I’ll update the fix shortly. > > With best regards. Petr. > > 06 марта 2014 г., в 2:49 после полудня, Sergey Bylokhov > <[email protected]> написал(а): > >> Hi, Petr. >> I guess JFIF is not a typo in CDataTransferer? Do we really need >> ImageTransferTest.html in the test? >> Also copyright header is missing. >> >> On 3/5/14 8:23 PM, Petr Pchelko wrote: >>> Hello, AWT Team. >>> >>> Please review the fix for the issue: >>> https://bugs.openjdk.java.net/browse/JDK-8030710 >>> The fix is available at: >>> http://cr.openjdk.java.net/~pchelko/9/8030710/webrev/ >>> >>> The problem was that on Mac we thought that re support PNG and JPEG image >>> formats, but in reality we did not have mappings for these formats. I've >>> added the missing mappings. >>> >>> The test is being open sourced. The fix was checked with out tests and with >>> native-Java DnD. >>> >>> With best regards. Petr. >> >> >> -- >> Best regards, Sergey. >> >
