Hello, Dmitry. 1. Do we need to print the delay? I don’t think it’s necessary. 2. The robot could be used in the tests with a SecurityManager, so you should wrap the getProperty in a privileged block. 3. The property should be advertised in the JavaDoc. 4. Robot should probably be thread-safe, so it’s better to make syncDelay final as you are not allowing to change it and set it upon construction.
With best regards. Petr. 03 апр. 2014 г., в 5:40 после полудня, Dmitriy Ermashov <[email protected]> написал(а): > Hi, > Please, review the changeset for: > https://bugs.openjdk.java.net/browse/JDK-8038631 > > Webrev is here: > http://cr.openjdk.java.net/~yan/8038631/webrev.03/ > > Last changes consist of: > 1. Year updated to 2014 in copyright note. > 2. Improve javadoc formatting. > 3. Removed non-public method "realSync()" mentions from javadoc. > 4. Method setSyncDelay replaced with automatic set on object creation > according to vm property. > > -- > Thanks, > Dima >
