Hello, Dmitriy. The new version looks good.
With best regards. Petr. On 29.04.2014, at 14:49, Dmitriy Ermashov <[email protected]> wrote: > Hi, > > Please review the changeset for > https://bugs.openjdk.java.net/browse/JDK-8041915 > > Webrev is here: > http://cr.openjdk.java.net/~yan/8041915/webrev.01/ > > Latest changes: > 1. If some translucency mode is not supported, the test will pass with > System.out warning message > 2. New method dragAndDrop implemented in ExtendedRobot class > > Thanks, > Dima > > On 04/25/2014 05:19 PM, Petr Pchelko wrote: >> Hello, Dmitriy. >> >> A couple of questions: >> >> 1. checkTranslucencyMode throws an exception if some mode is not supported >> on the device, so the test would fail. Should it? Normally we just skip the >> test if some capability is absent. >> 2. Didn't you consider moving the drag method into the ExtendedRobot? I >> expect it to be very commonly used. >> >> With best regards. Petr. >> >> On 25.04.2014, at 17:04, Dmitriy Ermashov <[email protected]> >> wrote: >> >>> Hi, >>> >>> Please review the changeset for >>> https://bugs.openjdk.java.net/browse/JDK-8041915 >>> >>> Webrev is here: >>> http://cr.openjdk.java.net/~yan/8041915/webrev.00/ >>> >>> -- >>> Thanks, >>> Dima >>> >
