Hi, Petr.
The fix looks good.
On 5/8/14 4:29 PM, Petr Pchelko wrote:
Hello,
Is anybody willing to make a second review on this fix?
With best regards. Petr.
On 30.04.2014, at 13:42, Alexander Zvegintsev <[email protected]>
wrote:
Hello, Petr,
the fix looks good to me.
Thanks,
Alexander.
On 04/30/2014 01:04 PM, Petr Pchelko wrote:
Hello,
It's a reminder about this review.
With best regards. Petr.
On 21.04.2014, at 16:34, Petr Pchelko <[email protected]> wrote:
Hello, AWT Team.
Please review the fix for the issue:
https://bugs.openjdk.java.net/browse/JDK-8036917
The fix is available at:
http://cr.openjdk.java.net/~pchelko/9/8036917/webrev/
The problem:
We overretain native images so they are never deleted.
The solution:
When we return a native image pointer to Java it's retain count should be 1,
so in case we use alloc-init we should not use retain. The image will be deleted
in CFRetainedResource.dispose
It's impossible to make a regression test.
With best regards. Petr.
--
Best regards, Sergey.
