The backport looks good for me.

  Thanks,
  Alexandr.

On 5/23/2014 2:33 PM, Anton Litvinov wrote:
Hello Sergey and Alexander,

On "jdk7u-dev" e-mail alias my request to push this backport was rejected and I was obligated to pass the regular code review. Could you please review this back port to JDK 7 of the fix previously reviewed by you for JDK 8.

Bug: https://bugs.openjdk.java.net/browse/JDK-7160604
Webrev: http://cr.openjdk.java.net/~alitvinov/7160604/jdk7/webrev.00
JDK 8 webrev: http://cr.openjdk.java.net/~bagiras/7160604.2

The back port fix is the same with the original fix, except for the regression test "test/javax/swing/JPopupMenu/7160604/bug7160604.java", where the original lambda expression

50         SwingUtilities.invokeLater(() -> {

was changed for

50         SwingUtilities.invokeLater(new Runnable() {
51             @Override
52             public void run() {

because JDK 7 does not support lambda expressions and the original test could not be compiled by JDK 7.

Anton Litvinov

Reply via email to