Hi all,
Sorry for the delay.
Please review new version of webrev:
http://cr.openjdk.java.net/~dermashov/8044765/webrev.01/
Last changes:
1. Long strings were splitted
2. InterJVM.java test started to use process helpers
3. MouseMovedTest - added volatile modificator to "moved" variable
Thanks,
Dima
On 06/04/2014 03:08 PM, Petr Pchelko wrote:
Hello, Dmitriy.
A couple of comments:
1. Could you please split loooong lines in ActionCommand.java,
ModalityTest.java, MouseEventMaskTest.java, TrayIconEventModifiersTest.java,
TrayIconEventsTest.java, TrayIconPopupTest.java
2. For interprocess communication we have special helpers in
java/awt/regtesthelpers/process. You could reuse them to simplify InterJVM.java
3. MouseMovedTest - moved should be volatile
Thank you.
With best regards. Petr.
On 04 июня 2014 г., at 13:24, Dmitriy Ermashov <[email protected]>
wrote:
Hi team,
It is new batch of functional tests, system tray tests this time.
Please review the change set:
http://cr.openjdk.java.net/~dermashov/8044765/webrev.00/
The fix also contains new test MouseMovedTest for verifying bug 7153700
--
Thanks,
Dima