Hi Alexey, The fix looks fine to me.
-- best regards, Anthony On 6/9/2014 5:19 PM, Alexey Ivanov wrote:
Hi Petr, Anthony, AWT and Swing teams, Could you please review the following webrev for JDK-8046239 to fix build failure: http://cr.openjdk.java.net/~aivanov/8046239/jdk9/webrev.01/ The build failure is caused by my fix to JDK-8039383: NPE when changing Windows Theme. I didn't test build thoroughly on other platforms. Sorry about that. There's a stub version of ThemeReader.java in src/solaris/classes/sun/awt/windows/ which is used for non-Windows builds. I added isXPStyleEnabled() function which always returns false. Also I removed the dependency on WToolkit from XPStyle: it uses "win.xpstyle.themeActive" to access the desktop property as it used to do. WindowsLookAndFeel can be instantiated on all the platforms but it can be used only on Windows because WindowsLookAndFeel.isSupportedLookAndFeel() returns false on any other platform but Windows. I am really sorry about build failure. I won't make it happen again. Thanks, Alexey.
