I've removed the unused import as Anthony suggested.
http://cr.openjdk.java.net/~pchelko/9/8047799/webrev.01/src/share/classes/java/awt/Dialog.java.sdiff.html
43 import java.util.function.BooleanSupplier;
Kinda haven't... :)
Although the rest of the fix still looks good to me.
--
best regards,
Anthony
On 6/26/2014 1:12 PM, Petr Pchelko wrote:
Hello,
Please review the updated version:
http://cr.openjdk.java.net/~pchelko/9/8047799/webrev.01/
I've removed the unused import as Anthony suggested.
Also the Component.windowClosingException is not used any more, so the variable
was removed.
With best regards. Petr.
On 24 июня 2014 г., at 15:33, Anthony Petrov <anthony.pet...@oracle.com> wrote:
Thanks!
--
best regards,
Anthony
On 6/23/2014 10:04 PM, Petr Pchelko wrote:
Hello, Anthony.
Out of curiosity, is the import BooleanSupplier statement in Dialog.java only needed to
please the compiler when using "() -> true"? Does the code not compile w/o the
import?
IDE has put it there for some reason. It’s not needed, I’ll remove it before
the push.
With best regards. Petr.
On Jun 23, 2014, at 9:50 PM, Anthony Petrov <anthony.pet...@oracle.com> wrote:
Looks fine.
Out of curiosity, is the import BooleanSupplier statement in Dialog.java only needed to
please the compiler when using "() -> true"? Does the code not compile w/o the
import?
--
best regards,
Anthony
On 6/23/2014 1:46 PM, Petr Pchelko wrote:
Hello, AWT Team.
Please review a weekly-cleanup fix for the issue:
https://bugs.openjdk.java.net/browse/JDK-8047799
The fix is available at:
http://cr.openjdk.java.net/~pchelko/9/8047799/webrev/
This feature was added for plugin in 1.4. I've grepped the sources and the
interfaces and methods are not used any more.
I've run modality JTREG and checked the test for an original bug, everything
seems to work fine. JPRT build succeeds.
With best regards. Petr.
