Hello, Alan. > I'm skimmed over the updated webrev, it mostly looks good except for > getFlavorMap where it doesn't set map, I assume you meant to do this: > > if (map == null) > flavorMap = map = supplier.get(); Thank you! Updated the fix: http://cr.openjdk.java.net/~pchelko/9/8037485/webrev.03/
With best regards. Petr. On 23 июля 2014 г., at 17:27, Alan Bateman <alan.bate...@oracle.com> wrote: > On 23/07/2014 09:25, Petr Pchelko wrote: >> Hello, Alan. >> >> Thank you for the review. >> I've updated the fix according to your comments. The new version is here: >> http://cr.openjdk.java.net/~pchelko/9/8037485/webrev.02/ >> >> Only the DataFlavorUtil file is updated. DesktopService now uses a lazy >> holder, the doc is fixed, the getFlavorTable method is fixed. >> All the rest is the same as in the previous version. > I'm skimmed over the updated webrev, it mostly looks good except for > getFlavorMap where it doesn't set map, I assume you meant to do this: > > if (map == null) > flavorMap = map = supplier.get(); > > -Alan > >
