Thanks for the review.

Just one more fix to review to finish suppressing the deprecation warnings in the desktop module; please also see the review request for JDK-8067086: Suppress mac-specific deprecation warnings in the java.desktop module:

http://mail.openjdk.java.net/pipermail/2d-dev/2014-December/004992.html
http://mail.openjdk.java.net/pipermail/awt-dev/2014-December/008790.html

Thanks,

-Joe

On 12/16/2014 9:24 AM, Phil Race wrote:
Approved.
We really need to figure out what to do about getPeer() - for this and for jigsaw ..

-phil.


On 12/16/2014 9:10 AM, joe darcy wrote:

On 12/16/2014 3:15 AM, Alan Bateman wrote:
On 16/12/2014 06:07, joe darcy wrote:
Hello,

Please review the next step of suppressing the deprecation warnings the client libraries, this time in windows-specific desktop code:

JDK-8067092: Suppress windows-specific deprecation warnings in the java.desktop module
    http://cr.openjdk.java.net/~darcy/8067092.0/

Thanks,
Lots more getPeer :-)

The change looks okay to me and the same techniques to reduce these as per the other thread.


Yes, same techniques as before -- for each warning, add "@SuppressWarning("deprecation")" to the enclosing method (or to the field for a field initializer expression). Some @SuppressWarning annotations cover multiple warning instances.

Thanks,

-Joe



Reply via email to