Hi, Semyon.
The fix looks fine, but I worry about possible infinite loops, since we
have a loop here peer->componet->peer. Please check the next use case:
TextField.setBackground()->*peer.setBackground()*->JTextComponent.setBackground()->*peer.setBackground()*
Will it works?
On 09.06.15 19:43, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8085895
webrev: http://cr.openjdk.java.net/~ssadetsky/8085895/webrev.00/
In 8074028 overridden getPeer() was simply removed in XWindows peers
of TextField and TextArea but that was not enough to preserve the
components functionality.
In the new design Component.getPeer() doesn't exist anymore. To
restore the previous logic completely it requires to override in the
peer delegate component all the Component methods those used getPeer()
before. But I think that would be a bad piece of code. I propose more
short fix that was tested to be working using jtreg TextFiled/* and
TextArea/* tests.
--Semyon
--
Best regards, Sergey.
