The fix looks good to me.
Thanks,
Alexandr.
On 7/29/2015 6:54 PM, Alexander Zuev wrote:
Looks fine to me.
/Alex
On 29/07/15 18:51, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk9.
In the fix 8068886[1] the new native resources deallocation code
assumes that we have a full control over the Cocoa NSApplication.
This is incorrect in case of embedding, when NSApplication is
controlled by swt or fx libraries. In the fix I add an additional
check that the necessary selector exists in the current NSApp.
[1] http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/b26427c5b3fe
Bug: https://bugs.openjdk.java.net/browse/JDK-8132382
Webrev can be found at:
http://cr.openjdk.java.net/~serb/8132382/webrev.02