On 8/27/2015 1:12 PM, pooja chopra wrote:
Hi Alexandr,
Please review updated webrev link :-
http://cr.openjdk.java.net/~pchopra/8130481/webrev.06/
There are some problems with the code indentation like :
------------------
if (SystemTray.isSupported()) {
SwingUtilities.invokeAndWait(new Runnable() {
public void run() {
createGui();
}
});
---------------
We have some requirements about it. See for example:
Java Code Conventions:
http://www.oracle.com/technetwork/java/codeconventions-150003.pdf
new discussed Java Style Guidelines:
http://cr.openjdk.java.net/~alundblad/styleguide
You could also use code formatting in your IDE to properly format the
code.
Thanks,
Alexandr.
Regards,
Pooja
On 8/5/2015 2:46 PM, Alexander Scherbatiy wrote:
On 8/5/2015 10:31 AM, pooja chopra wrote:
Hi Alexandr,
Please review update webrev link :-
The webrev is : http://cr.openjdk.java.net/~pchopra/8130481/webrev.03/
This looks better. There are just minor issues:
- run swing components on EDT like: menu.show(frame, 0, 0)
- format the code in 'if' block or check the mercurial settings
in .hgrc file like diff = -w // ignore white space when comparing lines
Thanks,
Alexandr.
Regards,
Pooja
On 7/29/2015 4:04 PM, Alexander Scherbatiy wrote:
On 7/29/2015 9:12 AM, pooja chopra wrote:
Hello Sergey ,
Please review update webrev link below :-
The webrev is :
http://cr.openjdk.java.net/~pchopra/8130481/webrev.02/
After the SystemTray.isSupported() is checked it is not
expected that the UnsupportedOperationException is thrown. The test
should fail in this case.
Thanks,
Alexandr.
Regards,
Pooja
On 7/16/2015 12:32 AM, Sergey Bylokhov wrote:
Hello,
I suggest to check support of systemTray at the beginning of the
test.
On 15.07.15 13:07, pooja chopra wrote:
Hello ,
Corrected the webrev link below . Please review.
Regards,
Pooja
On 7/15/2015 3:26 PM, pooja chopra wrote:
Hello,
Please review a fix for issue :-
8130481 [TEST_BUG]
javax/swing/JPopupMenu/6583251/bug6583251.java failed with
UnsupportedOperation exception
Test bug fix.
https://bugs.openjdk.java.net/browse/JDK-8130481
The webrev is :
http://cr.openjdk.java.net/~pchopra/8130481/webrev.01/
Regards,
Pooja