Too late, I just committed... If people have second thoughts, this change should be watered down rather than reverted anyways, so an independent followup change seems reasonable.
On Thu, Sep 17, 2015 at 9:10 AM, Phil Race <philip.r...@oracle.com> wrote: > +1 ( ie approved). May need a core-libs reviewer too ? > > -phil. > > On 9/16/2015 10:53 AM, Martin Buchholz wrote: > >> Webrev regenerated >> >> http://cr.openjdk.java.net/~martin/webrevs/openjdk9/usr-dt-environment/usr-dt-environment.patch >> < >> http://cr.openjdk.java.net/%7Emartin/webrevs/openjdk9/usr-dt-environment/usr-dt-environment.patch> >> >> and is now the best kind of change, a pure-deletion change. >> >> On Wed, Sep 16, 2015 at 9:00 AM, Phil Race <philip.r...@oracle.com >> <mailto:philip.r...@oracle.com>> wrote: >> >> That is fine by me. If any one on awt-dev knows of a reason to keep it >> they should speak up. >> >> -phil. >> >> >> On 9/15/15 5:09 PM, Martin Buchholz wrote: >> >>> We would be entirely happy if the environment frobbing code were >>> to be deleted. >>> Should I change my code to do that? >>> >>> On Tue, Sep 15, 2015 at 3:49 PM, Phil Race >>> <philip.r...@oracle.com <mailto:philip.r...@oracle.com>> wrote: >>> >>> I don't understand that original assessment. >>> Switching to XAWT had no impact on this code except to make >>> it pointless. >>> i.e it did not prevent its execution. >>> >>> I doubt there is any code left in the JDK that will derive any >>> benefit from it still being there. All CDE/Motif & Xt related >>> code is gone. >>> This should have been removed along with it but was doubtless not >>> in plain sight to whoever did that. >>> >>> So unless I am missing something you could go further and >>> just delete it. >>> >>> -phil. >>> >>> >>> On 9/15/2015 3:13 PM, Martin Buchholz wrote: >>> >>> I reported this bug 12 years ago, but it was closed Will >>> Not Fix, and this year I see java programs crashing >>> because of it! >>> This is a partial fix. >>> >>> https://bugs.openjdk.java.net/browse/JDK-8136570 >>> https://bugs.openjdk.java.net/browse/JDK-4953367 >>> >>> http://cr.openjdk.java.net/~martin/webrevs/openjdk9/usr-dt-environment/ >>> < >>> http://cr.openjdk.java.net/%7Emartin/webrevs/openjdk9/usr-dt-environment/ >>> > >>> < >>> http://cr.openjdk.java.net/%7Emartin/webrevs/openjdk9/usr-dt-environment/ >>> > >>> >>> >>> >>> >> >> >
