The fix looks fine.

On 15.10.15 8:59, Semyon Sadetsky wrote:


On 10/13/2015 6:03 PM, Sergey Bylokhov wrote:
On 09/29/2015 08:51 PM, Semyon Sadetsky wrote:
Hello,

Please review fix for JDK9:

bug: https://bugs.openjdk.java.net/browse/JDK-8022334
webrev: http://cr.openjdk.java.net/~ssadetsky/8022334/webrev.00/

The Unity WM cannot switch top-level windows of different peers
inside one Java app, because they have different WM_CLASS property
and different WM_CLASS are treated as different applications. This
issue is the root cause why a single Java app that contains multiple
top-level windows is shown as several groups of apps in the taskbar.
And it makes impossible to "lock" multi-window Java app in the Unity
taskbar because desktop shortcut should contain one WM_CLASS per app.
As a fix it is proposed to use the same WM_CLASS value for all peer
classes.

Should we also set the same hint for GTK FileChooser widget in
GtkFileDialogPeer?
This is not in this bug scope.  JDK doesn't set any wm class for GTK
FileChooser dialog. But it can be worth to add it. I filed a separate
bug for that https://bugs.openjdk.java.net/browse/JDK-8139635.

@Alexander Z, it seems this application name can be covered by your JEP.




--
Best regards, Sergey.

Reply via email to