Hello Mike,

The following changes have been contributed during JDK Mac OS X port developing:
http://hg.openjdk.java.net/macosx-port/macosx-port/jdk/rev/9023fa7e47c9

src/macosx/native/sun/awt/AWTView.m
---------------------
+    if (dropTarget != nil)
+        dragOp = [dropTarget draggingEntered:sender];
+    else if ([super respondsToSelector:@selector(draggingEntered:)])
+        dragOp = [super draggingEntered:sender];
---------------------

May be you could know why it was necessary to check dragging* selectors in super class when the super class is NSView which does not define them.

Thanks,
Alexandr.

On 10/8/2015 7:32 PM, Sergey Bylokhov wrote:
Hi, Alexander.
I suggest to investigate why we try to call a methods of our parent class when we know that these methods do not exist.

On 08.10.15 11:51, Alexander Scherbatiy wrote:
On 10/7/2015 5:38 PM, Alexander Scherbatiy wrote:
On 10/7/2015 5:25 PM, Semyon Sadetsky wrote:
Hi Alexander,

I wonder, what is the reason for main/othervm in the test if it
starts a separate process anyway?

    I do not have any particular reason to use it.

     I removed the othervm option from the run tag:
        http://cr.openjdk.java.net/~alexsch/8139050/webrev.01

     Thanks,
     Alexandr.

  Thanks,
  Alexandr.


--Semyon


On 10/7/2015 5:09 PM, Alexander Scherbatiy wrote:

Hello,

Could you review the fix:
  bug: https://bugs.openjdk.java.net/browse/JDK-8139050
  webrev: http://cr.openjdk.java.net/~alexsch/8139050/webrev.00

  [super respondsToSelector:@selector(draggingEnded:)] always
returns true because AWTView instance responds to -draggingEnded:
selector.
  The [[AWTView superclass]
instancesRespondToSelector:@selector(draggingEnded:)] should be used
instead.


Thanks,
Alexandr.







Reply via email to