The JDK fixes should be pushed to the JDK 9 first and then be
back-ported to JDK 8.
Could you prepare the fix for JDK 9?
Thanks,
Alexandr.
On 3/12/2016 3:23 AM, Hendrik Schreiber wrote:
Thanks, Alexander.
Can you also review it?
-hendrik
On Mar 11, 2016, at 19:06, Alexander Scherbatiy
<alexandr.scherba...@oracle.com
<mailto:alexandr.scherba...@oracle.com>> wrote:
I have uploaded the webrev to the cr.openjdk.java.net
<http://cr.openjdk.java.net>:
http://cr.openjdk.java.net/~alexsch/hendrik.schreiber/8151385/webrev.00/
Thanks,
Alexandr.
On 11/03/16 20:10, Hendrik Schreiber wrote:
Hey there,
I would very much appreciate a review (and a sponsor) for this JDK
8u fix.
Thanks so much!
-hendrik
On Mar 7, 2016, at 16:47, Hendrik Schreiber <h...@tagtraum.com
<mailto:h...@tagtraum.com>> wrote:
Hey there,
Could someone please review this fix for JDK8u.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8151385
Webrev:
https://www.beatunes.com/download/webrev-8151385.zip
Issue:
On Windows 10 with a HiDPI display, the icons in JOptionsPanes are
only partially displayed (screenshot in the bug report).
Fix:
Changed the methods that create BufferedImages from Windows bitmaps
so the actual bitmap size is taken into account.
Background: Windows 10 delivers differently sized bitmaps based on
display resolution.
Automated Test:
The error icon displayed by JOptionsPanes is round and as such the
pixels in all four corners are identical (transparent).
If the error occurs, at least the pixel in the lower right corner
is not the same as the one on the upper left corner. The test
checks, that the pixels in all four corners are identical. This
makes sure the test also succeeds on standard DPI displays.
For the test to actually fail (without the fix), this test needs to
be run on a Windows 10 system with a HiDPI display.
I have tested this on Windows 7 and Windows 10.
I have not tested it on Vista or Windows 8.x.
Thanks,
-hendrik
