On 22.03.16 9:54, Semyon Sadetsky wrote:
The test instruction:
> Please check if both of them have correct size and
> the same colouring (white rectagle in a blue mount). In this case
please push "Pass".
It is unclear how does it test the fix?
Correct/incorrect size criteria should be revealed better.
However, it is hard to count pixels on the screen by eye. I propose to
make the criteria more obvious to testers by selection of the image
dimensions and content.
What do you mean by "by selection of the image dimensions and content"?
The user cannot select the size of the resulted image because the image
occupy the whole tray and scales if necessary, and the color is defined
already as "white rectangle in a blue mount".
The tester will get two icons and he should check that they have same
size and have "the same colouring (white rectangle in a blue mount)". I
doubt that he will be able to check the size of the image in pixels and
the resulted color seems described clearly.
On 3/15/2016 3:54 AM, Sergey Bylokhov wrote:
Hello,
Please review the small fix for jdk9.
According to specification if imageAutoSize property was set to true
the image should be the stretched or shrunk to fit the tray icon
space. But on OSX this flag is ignored in the native code.
In the fix this flag is taken into account, if it was set to true.
otherwise the previous logic is executed:
- Small images are placed as is.
- Big images are proportionally down-scaled(I suppose this is done for
some usability issue)
Bug: https://bugs.openjdk.java.net/browse/JDK-8151773
Webrev can be found at:
http://cr.openjdk.java.net/~serb/8151773/webrev.00
--
Best regards, Sergey.
