+1
-yan
On 04/15/2016 08:28 AM, Ajit Ghaisas wrote:
Thanks Yuri.
Here is the updated webrev with suggested change.
http://cr.openjdk.java.net/~aghaisas/8031423/webrev.01/
Regards,
Ajit
-----Original Message-----
From: Yuri Nesterenko
Sent: Thursday, April 14, 2016 6:48 PM
To: Ajit Ghaisas; Sergey Bylokhov; awt-dev@openjdk.java.net
Subject: Re: JDK-8031423 : Test
java/awt/dnd/DisposeFrameOnDragCrash/DisposeFrameOnDragTest.java fails by
Timeout on Windows
Hi Ajit,
it's good you didn't change java.awt.Robot!
As to the test, you have created that instance of Robot:
now, pass it to Util.waitForIdle() and not recreate every time.
Thanks,
-yan
On 04/14/2016 02:59 PM, Ajit Ghaisas wrote:
Hi,
Adding delay in test code in main thread fixes this test timeout.
I considered adding some delay in Robot.waitForIdle() method so that the
calling thread yields, but realized that, it will have undesirable effect of
slowing down test runs as many tests use that method.
This fix contains moving robot creation up and adding delay to the test.
Request you to review webrev :
http://cr.openjdk.java.net/~aghaisas/8031423/webrev.00/
Regards,
Ajit