Hi, Semyon.
The new code in the CallProxyDefWindowProc() became similar to the code
in old jdk. In jdk5 and jdk6 the "::DefWindowProc()" was used, and
it seems was replaced by "ComCtl32Util::GetInstance().DefWindowProc"
later, can you please check why it was done.

On 21.04.16 16:53, Alexandr Scherbatiy wrote:

The fix looks good to me.

Thanks,
Alexandr.

On 4/18/2016 8:39 AM, Semyon Sadetsky wrote:


On 4/18/2016 6:12 PM, Alexander Scherbatiy wrote:
On 4/1/2016 1:29 PM, Semyon Sadetsky wrote:
Please review the updated version :
http://cr.openjdk.java.net/~ssadetsky/8147842/webrev.01/

fix was changed to avoid possible recursion in native IME evens
handling which the SendMessage() call might cause.

  The SendMessage call has been added by the fix  JDK-8079595
Resizing dialog which is JWindow parent makes JVM crash
  Could you give more details why removing this code back will not
cause new JVM crash?
I did not remove the code back. Before JDK-8079595 the DefSubclassProc
function was called actually (see ComCtl32Util::DefWindowProc). This
function is not threadsafe and that was the root cause of  the
JDK-8079595.

--Semyon

  Thanks,
  Alexandr.



--Semyon

On 3/31/2016 7:38 PM, Semyon Sadetsky wrote:


On 3/31/2016 7:11 PM, Semyon Sadetsky wrote:
The solution is to support positioning for the IME candidate window.

It should be : "the IME *composition* window" of cause...

--Semyon







--
Best regards, Sergey.

Reply via email to