Hi All,
Gentle remainder for one more review for this code change
Thank you Ambarish.
Best Regards,
Ramesh BG
From: Ambarish Rapte
Sent: Wednesday, April 20, 2016 12:43
To: Ramesh Gangadhar; awt-dev@openjdk.java.net
Subject: RE: <AWT Dev> Review Request For 8129569 : Test
java/awt/Frame/MaximizedToUnmaximized/MaximizedToUnmaximized.java fails
Hi Ramesh,
Fix looks good to me.
Regards,
Ambarish
From: Ramesh Gangadhar
Sent: Tuesday, April 19, 2016 11:10 AM
To: HYPERLINK "mailto:awt-dev@openjdk.java.net"awt-dev@openjdk.java.net
Subject: Re: <AWT Dev> Review Request For 8129569 : Test
java/awt/Frame/MaximizedToUnmaximized/MaximizedToUnmaximized.java fails
Hello All,
This is a gentle remainder for review.
Best Regards,
Ramesh BG
From: Ramesh Gangadhar
Sent: Thursday, April 14, 2016 19:40
To: HYPERLINK "mailto:awt-dev@openjdk.java.net"awt-dev@openjdk.java.net
Subject: Re: <AWT Dev> Review Request For 8129569 : Test
java/awt/Frame/MaximizedToUnmaximized/MaximizedToUnmaximized.java fails
Hi,
Please review fix for bug 8129569 in JDK 9
BUG ID: https://bugs.openjdk.java.net/browse/JDK-8129569
Webrev: http://cr.openjdk.java.net/~arapte/ramesh/8129569/webrev.01/
Issue:
While checking for Frame State when Maximum bounds is set in Mac and Ubuntu
Operating system sets state = Frame.MAXIMIZED_BOTH but this is not true in
other operating system.
Fix:
Code modified to set state = Frame.NORMAL when maximum bounds is set to Frame
in other operating systems apart from Ubuntu and Mac.
Added command "uname -v" to check whether operating system is Ubuntu or not
since using alone 'System.getProperty("os.name") will not be able to decide
operating system as it returns "Linux" for Ubuntu also.
Verification:
1. Windows 7 returns NORMAL state for frame when maximum bounds is set to
Frame.
2. Oracle Linux 6.4 returns NORMAL state for frame when maximum bounds is
set to Frame.
3. Solaris returns NORMAL state for frame when maximum bounds is set to
Frame.
4. Ubuntu returns MAXIMIZED_BOTH state for frame when maximum bounds is
set to Frame.
5. Mac returns MAXIMIZED_BOTH state for frame when maximum bounds is set
to Frame
@Ambarish: Thank you for pointing to Ubuntu.
Best Regards,
Ramesh BG
From: Ambarish Rapte
Sent: Thursday, April 14, 2016 1:57 PM
To: Ramesh Gangadhar; HYPERLINK
"mailto:awt-dev@openjdk.java.net"awt-dev@openjdk.java.net
Subject: RE: <AWT Dev> Review Request For 8129569 : Test
java/awt/Frame/MaximizedToUnmaximized/MaximizedToUnmaximized.java fails
Hi Ramesh,
Please check the test fails on 64 bit Ubuntu 14.04 LTS.
Thanks,
Ambarish
From: Ramesh Gangadhar
Sent: Thursday, April 14, 2016 12:04 PM
To: HYPERLINK "mailto:awt-dev@openjdk.java.net"awt-dev@openjdk.java.net
Subject: <AWT Dev> Review Request For 8129569 : Test
java/awt/Frame/MaximizedToUnmaximized/MaximizedToUnmaximized.java fails
Hi,
Please review fix for bug 8129569 in JDK 9
BUG ID: https://bugs.openjdk.java.net/browse/JDK-8129569
Webrev: http://cr.openjdk.java.net/~jdv/Ramesh/8129569/webrev.00/
Issue:
While checking for Frame State when Maximum bounds is set Mac Operating system
sets state = Frame.MAXIMIZED_BOTH but this is not true in other operating
system.
Fix:
Code modified to set state = Frame.NORMAL when maximum bounds is set to Frame
in other operating systems.
Best Regards,
Ramesh BG
