Looks fine. Regards, Rajeev Chamyal
-----Original Message----- From: Sergey Bylokhov Sent: 04 May 2016 20:13 To: Ambarish Rapte; Semyon Sadetsky; Prasanta Sadhukhan; Rajeev Chamyal; [email protected] Subject: Re: Review request for 8155742 : [Windows] robot.keyPress(KeyEvent.VK_ALT_GRAPH) throws java.lang.IllegalArgumentException in windows Looks fine. On 03.05.16 19:37, Ambarish Rapte wrote: > Hi, > > Please review fix for JDK9, > > Bug: https://bugs.openjdk.java.net/browse/JDK-8155742 > > Webrev: > http://cr.openjdk.java.net/~arapte/8155742/webrev.00/ > > > > > > Issue: > > robot.keyPress(KeyEvent.VK_ALT_GRAPH) throws > java.lang.IllegalArgumentException in windows > > > > Cause: > > KeyEvent .VK_ALT_GRAPH is not supported by Robot. > > > > Fix: > > Added VK_ALT_GRAPH key support under Robot for Windows. > > VK_RMENU is an extended key, hence added flag KEYEVENTF_EXTENDEDKEY > while calling keybd_event. > > Doc: keybd_event() > > https://msdn.microsoft.com/en-us/library/windows/desktop/ms646304(v=vs > .85).aspx > > > > > > Verification: > > The change is specific to extended, VK_RMENU key. > > Hence existing robot behavior does get affected & no > tests should fail. > > > > Verified by executing regression & JCK tests of Event, > Robot, Keyboard. > > No existing test fails due to this change. > > > > > > > > Regards, > > Ambarish > > > -- Best regards, Sergey.
