Looks fine.
On 14.05.16 4:46, Daniil Titov wrote:
Thank you all for reviewing these changes. Per Stuart's recommendations I've
updated the documentation.
Please review the new version of the fix.
Webrev : http://cr.openjdk.java.net/~dtitov/8155785/webrev.01/
Bug: https://bugs.openjdk.java.net/browse/JDK-8155785
Best regards,
Daniil
-----Original Message-----
From: Stuart Marks
Sent: Friday, May 13, 2016 2:32 PM
To: Daniil Titov
Cc: Philip Race; Sergey Bylokhov; awt-dev@openjdk.java.net
Subject: Re: <AWT Dev> [9] Review Request: 8155785 Add @Deprecated annotations
to the Applet API classes
@deprecated As of JDK 9, the Applet API is deprecated, no replacement.
I don't think it's necessary to say "As of JDK 9" since the annotation itself has
since="9" in it.
The text seems like it's missing something. It's true there is no direct
replacement for the Applet API. But somebody looking to migrate an Applet to
something else will be left hanging. The JEP 289 text says,
Guide developers to alternative technologies such as Java Web Start or
installable applications.
I'd suggest that a couple sentences be added to the java.applet package
documentation saying that the APIs in this package are all deprecated and to
suggest, per the JEP, migrating to Java Web Start or to an installable
application. Links would also be good as appropriate. It needn't be a big
essay; a couple sentences should be sufficient.
Then, each class can simply refer to the package doc:
* @deprecated The Applet API is deprecated. See the
* <a href="package-summary.html>java.applet package documentation</a>
* for further information.
s'marks
On 5/12/16 6:41 PM, Daniil Titov wrote:
Hello,
Please review the fix for JDK 9.
The fix adds @Deprecated annotations to the Applet API classes as per
JEP 289 "Deprecate the Applet API" ( http://openjdk.java.net/jeps/289 ).
@SuppressWarnings("deprecation") annotations were added where required
to suppress the compilation warnings that treated as errors.
Bug: https://bugs.openjdk.java.net/browse/JDK-8155785
Webrev : http://cr.openjdk.java.net/~dtitov/8155785/webrev.00
Best regards,
Daniil
--
Best regards, Sergey.