Looks fine, but please confirm that the test will fail on jdk where
JDK-8012026 is not fixed.
On 17.05.16 12:25, Ramesh Gangadhar wrote:
Gentle reminder for one more review.
Best Regards,
Ramesh BG
*From:* Ambarish Rapte
*Sent:* Thursday, May 12, 2016 11:38
*To:* Ramesh Gangadhar; awt-dev@openjdk.java.net
*Subject:* RE: <AWT Dev> FW: Review Request for 8027154: Test
java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails
Hi Ramesh,
The fix looks fine to me.
Regards,
Ambarish
*From:*Ramesh Gangadhar
*Sent:* Wednesday, May 04, 2016 8:27 PM
*To:* awt-dev@openjdk.java.net <mailto:awt-dev@openjdk.java.net>
*Subject:* <AWT Dev> FW: Review Request for 8027154: Test
java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails
Hi All,
This is a Gentle reminder for review.
Best Regards,
Ramesh BG
*From:* Ramesh Gangadhar
*Sent:* Thursday, April 28, 2016 12:21
*To:* awt-dev@openjdk.java.net <mailto:awt-dev@openjdk.java.net>
*Cc:* Ambarish Rapte
*Subject:* RE: <AWT Dev> Review Request for 8027154: Test
java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails
Hi All,
Gentle remainder for review.
Here is the updated webrev location:
http://cr.openjdk.java.net/~arapte/ramesh/8129569/webrev.03/
@Ambarish:
1. removed all System.out.println() calls.
2. Aligned all lines to 80 chars.
3. By removing robot.delay() I can see like testcase is failing
some of machines, so I have included robot.delay(500) to pass this testcase.
Best Regards,
Ramesh BG
*From:* Ambarish Rapte
*Sent:* Thursday, April 21, 2016 06:31
*To:* Ramesh Gangadhar; awt-dev@openjdk.java.net
<mailto:awt-dev@openjdk.java.net>
*Subject:* RE: <AWT Dev> Review Request for 8027154: Test
java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails
Hi Ramesh
The fix looks good.
However, could you please check if the test can be run without the 6000
delay.
Please arrange the lines to 80 char length.
Please remove the System.out.println() calls.
Regards,
Ambarish
*From:*Ramesh Gangadhar
*Sent:* Tuesday, April 19, 2016 11:09 AM
*To:* awt-dev@openjdk.java.net <mailto:awt-dev@openjdk.java.net>
*Subject:* Re: <AWT Dev> Review Request for 8027154: Test
java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails
Hello All,
This is a gentle remainder for review.
Best Regards,
Ramesh BG
*From:* Ramesh Gangadhar
*Sent:* Tuesday, April 12, 2016 14:41
*To:* awt-dev@openjdk.java.net <mailto:awt-dev@openjdk.java.net>
*Subject:* Re: <AWT Dev> Review Request for 8027154: Test
java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails
Hello,
Please review bug fix for 8027154
bug: https://bugs.openjdk.java.net/browse/JDK-8027154
Webrev: http://cr.openjdk.java.net/~ralexander/8027154/webrev.02/
*Issue:*
mouseMoved(MouseEvent) recieves sometimes position as [29,29] and
sometimes as [30,30] from AWT native code
*What modifications Done? *
Since this testcase is mainly focused on checking mouse position instead
of two Robot.mouseMove(149,149) and Robot.mouseMove(150,150) method
calls it is reduced to only one call of Robot.mouseMove(150,150) and
also removed creation of OuterFrame when mouseMoved on InnerFrame.
*Verification:*
Code Tested on Windows and oracle linux for verification.
Best Regards,
Ramesh BG
*From:* Ambarish Rapte
*Sent:* Monday, April 04, 2016 4:56 PM
*To:* Ramesh Gangadhar; awt-dev@openjdk.java.net
<mailto:awt-dev@openjdk.java.net>
*Subject:* RE: <AWT Dev> Review Request for bug JDK-8027154
Hi Ramesh,
Below are few comments,
General comments :
1. Please provide description about bug cause & how this change
fixes the bug, with the review email.
Also update the bug on JBS with similar analysis.
2. Subject line for review email should in format, “Review
Request For BUG_ID : BUG summary line”
3. Remove wild card import statements, @author tag &
System.out.println lines.
Comments Specific to the test:
4. Passing null to Util.waitForIdle() creates a new robot object
at each call, instead please pass the created robot object.
5. The delay on line number 86 can be removed, Util.WaitForIdle()
should be sufficient for synchronization.
Thanks,
Ambarish
*From:*Ramesh Gangadhar
*Sent:* Friday, April 01, 2016 12:28 PM
*To:* awt-dev@openjdk.java.net <mailto:awt-dev@openjdk.java.net>
*Subject:* <AWT Dev> Review Request for bug JDK-8027154
Hello,
Please review fix for Bug 8027154
bug: https://bugs.openjdk.java.net/browse/JDK-8027154
webrev: http://cr.openjdk.java.net/~ralexander/8027154/webrev.01/
Best Regards,
Ramesh BG
--
Best regards, Sergey.
