Re: RFR: 8158458: Update references from "1.9" to "9"

[Iris Clark]

Hi, Phil.

Thanks for looking that this tiny change.

I agree with you regarding the usefulness of this tag, but I just noticed that 
they are @since tags exist for every single method in the class.  Since you are 
the owner of the code, it's your call to keep it or remove it.

Here's the alternative changeset with the @since tag removed:

src/java.desktop/macosx/classes/com/apple/eawt/Application.java
--- a/src/java.desktop/macosx/classes/com/apple/eawt/Application.java   Wed Jun 
01 11:22:06 2016 -0700
+++ b/src/java.desktop/macosx/classes/com/apple/eawt/Application.java   Thu Jun 
02 20:35:37 2016 -0700
@@ -372,7 +372,6 @@
      * Acceptable values are from 0 to 100, any other disables progress 
indication.
      *
      * @param value progress value
-     * @since 1.9
      */
     public void setDockIconProgress(final int value) {
         iconHandler.setDockIconProgress(value);

I'll use this unless you instruct me otherwise.  As discussed today, the plan 
is to push this small change to jdk9/dev.

Thanks,
iris

-----Original Message-----
From: Philip Race 
Sent: Wednesday, June 01, 2016 8:42 PM
To: Iris Clark
Cc: awt-dev@openjdk.java.net; compiler-...@openjdk.java.net
Subject: Re: <AWT Dev> RFR: 8158458: Update references from "1.9" to "9"

By which I mean "delete" is as good as "update'

-phil

On 6/1/16, 8:29 PM, Philip Race wrote:
> I don't see why @since matters on internal classes ...
>
> -phil.
>
> On 6/1/16, 6:17 PM, Iris Clark wrote:
>> Hi.
>>
>> I'm taking another pass at replacing instances of "@since 1.9" with 
>> "@since 9" and discovered a couple of jdk (AWT?) and langtools 
>> (DocTree) files which need to be updated.  I've filed the following 
>> but to address this problem:
>>
>>      8158458: Update references from "1.9" to "9" (closed code))
>>      https://bugs.openjdk.java.net/browse/JDK-8158458
>>
>> This is the necessary diff, against jdk9/dev:
>>
>> [/w/iclark/verona/javadoc/jdk]:
>> diff -r 0bd06ec69c5b
>> src/java.desktop/macosx/classes/com/apple/eawt/Application.java
>> --- a/src/java.desktop/macosx/classes/com/apple/eawt/Application.java
>> Wed Jun 01 11:22:06 2016 -0700
>> +++ b/src/java.desktop/macosx/classes/com/apple/eawt/Application.java
>> Wed Jun 01 17:40:09 2016 -0700
>> @@ -372,7 +372,7 @@
>>    * Acceptable values are from 0 to 100, any other disables progress 
>> indication.
>>    *
>>    * @param value progress value
>> - * @since 1.9
>> + * @since 9
>>        */
>>       public void setDockIconProgress(final int value) {
>>           iconHandler.setDockIconProgress(value);
>>
>> [/w/iclark/verona/javadoc/langtools]:
>> diff -r 2d1a6b746310
>> src/jdk.compiler/share/classes/com/sun/source/doctree/HiddenTree.java
>> ---
>> a/src/jdk.compiler/share/classes/com/sun/source/doctree/HiddenTree.ja
>> va
>> Wed Jun 01 12:39:24 2016 +0100
>> +++ 
>> b/src/jdk.compiler/share/classes/com/sun/source/doctree/HiddenTree.ja
>> va
>> Wed Jun 01 17:40:09 2016 -0700
>> @@ -34,7 +34,7 @@
>>    *<p>
>>    *&#064;hidden
>>    *
>> - * @since 1.9
>> + * @since 9
>>    */
>>   public interface HiddenTree extends BlockTagTree {
>>       /**
>>
>> Build and test runs show no regressions.
>>
>> Thanks,
>> Iris