Hello Semyon

Hi Dmitry,

The fix looks good.

The fix is good for me as well.

I am only not sure that an applet based test is suitable since applets are deprecated.

The Jtreg manual tests are supposed to be applets.

I consulted with the SQE team,
they have no objections for the applet based tests.

So I think this test is fine.

Thanks
alexp


--Semyon


On 6/17/2016 1:45 PM, dmitry markov wrote:
Hello,

Could you review a fix for jdk9, please?

    bug: https://bugs.openjdk.java.net/browse/JDK-8154816
    webrev: http://cr.openjdk.java.net/~dmarkov/8154816/webrev.00/

Problem description:
When Pinyin Simplified input method is selected and 'Caps Lock' is on, input is switched to latin letters, but letters are entered in uppercase.

Fix:
It is necessary to ignore 'Caps Lock' modifier in CPlatformResponder.handleKeyEvent() method, if Pinyin Simplified input method is selected and 'Caps Lock' is on.

Thanks,
Dmitry


Reply via email to