Looks good to me.
Regards, Rajeev Chamyal From: Semyon Sadetsky Sent: 23 June 2016 12:07 To: Ambarish Rapte; Prasanta Sadhukhan; Sergey Bylokhov; Alexander Scherbatiy; awt-dev@openjdk.java.net Subject: Re: <AWT Dev> Review request for 8151588: Press the button first two times, the 'First' and 'Next' didn't show Looks good to me. --Semyon On 6/23/2016 8:44 AM, Ambarish Rapte wrote: Hi, Gentle reminder. Please review. Regards, Ambaris From: Ambarish Rapte Sent: Wednesday, June 15, 2016 8:40 PM To: Prasanta Sadhukhan; Semyon Sadetsky; Sergey Bylokhov; Alexander Scherbatiy; HYPERLINK "mailto:awt-dev@openjdk.java.net"awt-dev@openjdk.java.net Subject: <AWT Dev> Review request for 8151588: Press the button first two times, the 'First' and 'Next' didn't show Hi, Please review this fix for JDK9, Webrev: http://cr.openjdk.java.net/~arapte/8151588/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8151588 Issue: When Text Area is not in focus, If select or append is called on Text Area and if the desired text is not in visible area then the Text Area should auto scroll to make the desired text visible. But this behavior was broken due to fix of, bug: https://bugs.openjdk.java.net/browse/JDK-6180449 Patch(1): http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/b9f91de8ae43 Fix: Issue JDK-6180449 is also fixed by fix of, https://bugs.openjdk.java.net/browse/JDK-8149636 http://hg.openjdk.java.net/jdk9/client/jdk/rev/4a1e160a12c3 Hence reverting the fix Patch(1) for JDK-6180449 to fix this regression. Verification: All JCK tests for Text Area pass, no other test fails due to this change. The newly added test with this fix, fails without the patch and passes after merging the patch. Regards, Ambarish
