Test looks good after suggested cleanup. Regards, Ajit
-----Original Message----- From: Sergey Bylokhov Sent: Wednesday, September 14, 2016 11:38 PM To: Manajit Halder Cc: Rajeev Chamyal; Ajit Ghaisas; awt-dev@openjdk.java.net Subject: Re: <AWT dev>[9] Review request for JDK-8163270: [macosx] Robot(gc) issue on dual-screen system. Looks fine, thanks! On 14.09.16 14:43, Manajit Halder wrote: > Hi Sergey, > > Thank you for your review comment. Code is modified and cleaned. > Please review the modified webrev. > > http://cr.openjdk.java.net/~mhalder/8163270/webrev.01/ > > Thanks, > Manajit > >> On 09-Sep-2016, at 10:08 pm, Sergey Bylokhov >> <sergey.bylok...@oracle.com <mailto:sergey.bylok...@oracle.com>> wrote: >> >> Hi, Manajit. >> I recognized that the test can be cleaned a little bit. We can move >> the code from the init() to main and remove all other unnecessary >> stuff: TestPassedException, pass(), setTimeoutTo(), etc. >> >> On 09.09.16 8:23, Manajit Halder wrote: >>> >>> Hi All, >>> >>> Kindly review the fix for JDK9. >>> >>> *Bug*: >>> _https://bugs.openjdk.java.net/browse/JDK-8163270_ >>> _ >>> _ >>> *Webrev*: >>> http://cr.openjdk.java.net/~mhalder/8163270/webrev.00/ >>> >>> *Issue: * >>> [macosx] Robot(gc) issue on dual-screen system. >>> >>> *Cause: * >>> Calculation of x coordinate value was wrong for the mouse cursor in >>> the extended monitor. >>> >>> *Fix: * >>> Calculation corrected for x coordinate. >>> >>> Regards, >>> Manajit >> >> >> -- >> Best regards, Sergey. > -- Best regards, Sergey.
