Hi, Manajit.
It seems that after the fix "(CRobotKeyCodeMapping *) sharedInstance"
returns the new object per invocation, so it is not really
sharedInstance. I am not sure I understand what is wrong in the current
code, from the my point of view this is a correct singleton. It it true
that the problem is in access to broken "instance" and not to
"javaToMacKeyMap" inside the "instance"? If not then "javaToMacKeyMap"
should be changed to "self.javaToMacKeyMap".
Do you have a test case to reproduce the bug?
On 19.09.16 15:26, Manajit Halder wrote:
Hi All,
Kindly review the fix for JDK9.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8165555
Webrev:
http://cr.openjdk.java.net/~mhalder/8165555/webrev.00/
Issue:
[macosx] VM crashes on second attempt to execute JCK interactive tests
that use Robot (single JVM, agent)
Cause:
While executing the JCK test for the second time the robot was getting
initialised once again and old instance of CRobotKeyCodeMapping was not
available.
Crash was observed while trying to access invalid instance of
CRobotKeyCodeMapping.
Fix:
A new instance of CRobotKeyCodeMapping is created when robot is initialised.
Regards,
Manajit
--
Best regards, Sergey.
