Hi Alexander,
The fix looks good.
I guess the second callback parameter was added by mistake initially.
Also I noticed after menu items added/removed a number of times GTK
prints messages:
(java:20921): GLib-CRITICAL **: g_hash_table_insert_internal: assertion
'hash_table != NULL' failed
(java:20921): GLib-GObject-WARNING **: invalid unclassed pointer in cast
to 'DbusmenuServer'
(java:20921): LIBDBUSMENU-GLIB-CRITICAL **: dbusmenu_menuitem_foreach:
assertion 'DBUSMENU_IS_MENUITEM(mi)' failed
and sometimes the process even cashes in libdbusmenu-glib.so.
Probably we need some protection from that.
--Semyon
On 06.09.2016 20:56, Alexander Zvegintsev wrote:
Hello,
please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8153526/00/
for the issue
https://bugs.openjdk.java.net/browse/JDK-8153526
