Thanks Anubhav,
Changes look fine to me.
Regards,
Ambarish
From: Anubhav Meena
Sent: Monday, October 10, 2016 5:06 PM
To: Ambarish Rapte
Cc: [email protected]
Subject: Re: <AWT Dev> <AWT dev>[9] Review request for JDK-8161473:[TEST_BUG]
[macosx] add autodelay to
java/awt/TrayIcon/TrayIconEventModifiers/TrayIconEventModifiersTest.java
Hi Ambarish,
Have made the changes you suggested. Please find them here
http://cr.openjdk.java.net/~rchamyal/anmeena/8161473/webrev.01/
Thanks,
Anubhav
On Oct 10, 2016, at 2:01 PM, Ambarish Rapte <HYPERLINK
"mailto:[email protected]"[email protected]> wrote:
Hi Anubhav,
Along with the fix, could you please add below trivial changes
as well,
1. Add @key headful & @bug 8161473 jtreg tags
2. Change wild card * import to add specific package imports.
3. Update copyright with year 2016.
Regards,
Ambarish
From: Anubhav Meena
Sent: Friday, October 07, 2016 6:46 PM
To: HYPERLINK "mailto:[email protected]"[email protected]
Subject: <AWT Dev> <AWT dev>[9] Review request for JDK-8161473:[TEST_BUG]
[macosx] add autodelay to
java/awt/TrayIcon/TrayIconEventModifiers/TrayIconEventModifiersTest.java
Hi All,
Kindly review the fix for JDK9.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8161473
Webrev:
http://cr.openjdk.java.net/~rchamyal/anmeena/8161473/webrev.00/
Issue:
[macosx] The test
java/awt/TrayIcon/TrayIconEventModifiers/TrayIconEventModifiersTest.java often
fails, especially on OS X.
Cause:
Lack of minimal delay between elementary robot operations
Fix:
Added wait for idle operation between two robot events.
Regards,
Anubhav