Hi Prasanta,
Thankyou for the Review. 8168291 is duplicate of 8168292, The suggested fix resolves issue both on Linux and OS X platforms . Regards, Prem From: Prasanta Sadhukhan Sent: Wednesday, October 26, 2016 12:02 PM To: Ajit Ghaisas; Prem Balakrishnan; Alexander Scherbatiy; Rajeev Chamyal; awt-dev@openjdk.java.net Subject: Re: <AWT Dev> Review Request : JDK-8168292 [TestBug]Test java/awt/TrayIcon/DragEventSource/DragEventSource.java fails on OS X Hi Prem, +1 to 8168292 but one thing is that this issue is created to enable to work on 8168291 and was mentioned that the problem DragEventSource fails on osx will be addressed as part of 8168292 which I do not see being done in your webrev. So, either open up 8168291 or fix it in this bug. Regards Prasanta On 10/25/2016 2:25 PM, Ajit Ghaisas wrote: Looks fine. Regards, Ajit From: Prem Balakrishnan Sent: Monday, October 24, 2016 3:16 PM To: Ajit Ghaisas; Alexander Scherbatiy; Rajeev Chamyal; HYPERLINK "mailto:awt-dev@openjdk.java.net"awt-dev@openjdk.java.net Subject: RE: <AWT Dev> Review Request : JDK-8168292 [TestBug]Test java/awt/TrayIcon/DragEventSource/DragEventSource.java fails on OS X Hi Ajit, Thankyou for the review. Updated patch as per review comments. HYPERLINK "http://cr.openjdk.java.net/%7Epkbalakr/8168292/webrev.01/"http://cr.openjdk.java.net/~pkbalakr/8168292/webrev.01/ Regards, Prem From: Ajit Ghaisas Sent: Monday, October 24, 2016 2:00 PM To: Prem Balakrishnan; Alexander Scherbatiy; Rajeev Chamyal; HYPERLINK "mailto:awt-dev@openjdk.java.net"awt-dev@openjdk.java.net Subject: RE: <AWT Dev> Review Request : JDK-8168292 [TestBug]Test java/awt/TrayIcon/DragEventSource/DragEventSource.java fails on OS X Hi Prem, I know this is compilation fix, but still few corrections can be made to the test. 1. Please replace generic imports to specific class imports. 2. First sentence of the instruction text has a typo - please correct it. Existing : "Use see a Frame with a button in it." Should be : "User sees a Frame with a button on it." Regards, Ajit From: Prem Balakrishnan Sent: Thursday, October 20, 2016 3:00 PM To: Alexander Scherbatiy; Rajeev Chamyal; HYPERLINK "mailto:awt-dev@openjdk.java.net"awt-dev@openjdk.java.net Subject: <AWT Dev> Review Request : JDK-8168292 [TestBug]Test java/awt/TrayIcon/DragEventSource/DragEventSource.java fails on OS X Hi, Please review the patch. Test Bug: https://bugs.openjdk.java.net/browse/JDK-8168292 Webrev: HYPERLINK "http://cr.openjdk.java.net/%7Epkbalakr/8168292/webrev.00/"http://cr.openjdk.java.net/~pkbalakr/8168292/webrev.00/ Compilation error: Can't find library\: ../../../regtesthelpers Fix: updated the library path Regards, Prem
