Re: [9] Request for review: JDK-8140525 AwtFrame::WmShowWindow() may steal focus

[Semyon Sadetsky]

+1

--Semyon


On 23.11.2016 17:24, Sergey Bylokhov wrote:

On 23.11.16 17:23, Anton Tarasov wrote:

It actually won't work, because m_visible is set ahead:

AwtFrame::Show()
{
    m_visible = true;
<...>
    ::ShowWindow(hwnd);
}

The latter call causes WM_SHOWWINDOW and causes
AwtFrame::WmShowWindow(BOOL show, UINT status).

So we have [window->isVisible() == true] whereas
[::IsWindowVisible(hwnd) == false] at the moment.

Thanks. Looks fine.