Looks  good to me.

 

Regards,

Prem

 

From: Manajit Halder 
Sent: Friday, February 10, 2017 2:56 PM
To: Sergey Bylokhov; Prem Balakrishnan
Cc: awt-dev@openjdk.java.net
Subject: <AWT dev>[9] Review request for JDK-7119774: [macosx] test 
ComponentMousePositionTest sometimes fail on Mac

 

Hi All,

 

Kindly review the fix for JDK9.

 

Bug: 

https://bugs.openjdk.java.net/browse/JDK-7119774

 

Webrev: 

http://cr.openjdk.java.net/~mhalder/7119774/webrev.00/

 

Issue: 

Test fails sometimes on the last stage because getMousePosition() was getting 
called before the mouseMove completes. 

 

Fix: 

Fixed the issue by adding a waitForIdle() call after the mouseMove.

Along with the fix the following changes were done:

                The test was cleaned up and moved from closed to open

                Removed applet code

                Manual test to automatic test

 

Regards,

Manajit

Reply via email to