Thank you for clarification.
The fix looks fine.
On 9/6/17 22:55, Pankaj Bansal wrote:
Hi Sergey,
Yes, I have verified this thing. The test passes for "Generic RGB profile" and
fails for other profiles with the proposed fix.
Regards,
Pankaj Bansal
-----Original Message-----
From: Sergey Bylokhov
Sent: Wednesday, September 6, 2017 8:54 PM
To: Pankaj Bansal; awt-dev@openjdk.java.net
Subject: Re: <AWT Dev> [10] Review Request: JDK-8154468 : [TEST_BUG]
java/awt/Window/MultiWindowApp/ChildAlwaysOnTopTest.java
Hi, Pankaj.
The description of the https://bugs.openjdk.java.net/browse/JDK-8181305
mentioned that non "Generic RGB profile" is used, but our tests expect to be run on "Generic RGB
profile" only. Please confirm that an updated fix in this bug will pass on osx if ""Generic
RGB" is used.
On 9/6/17 03:39, Pankaj Bansal wrote:
Hi All,
Please review the fix for test program
java/awt/Window/MultiWindowApp/ChildAlwaysOnTopTest.java for JDK 10.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8154468
Webrev:
http://cr.openjdk.java.net/~aghaisas/pankaj/8154468/webrev.0/
Issue:
java/awt/Window/MultiWindowApp/ChildAlwaysOnTopTest.java test fails
due to insufficient robot delay.
Fix:
Increased the delay for robot before calling robot.getPixelColor to
account for rendering delay.
Note:
The test passes on Windows and Linux with the given fix. However, it
fails on MacOS due to some other bug in the Robot.getPixelColor
functionality. It returns wrong color value for any pixel. The bug ID
for the issue is https://bugs.openjdk.java.net/browse/JDK-8181305
Regards,
Pankaj Bansal
--
Best regards, Sergey.
--
Best regards, Sergey.
