I need to look more closely but at a quick glance I don't see any
problems so a tentative +1 ..
but a final +1 will go in the bug.
Have you tested the various configurations .. running this on top of
current JDK (not FX) 10
both with and without the FX changes ?
-phil.
On 09/21/2017 10:56 PM, Alexander Zvegintsev wrote:
Hi Phil,
Please review the updated fix with reflection incorporated
http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/01/
New issue created JDK-8187803
<https://bugs.openjdk.java.net/browse/JDK-8187803> as JDK counterpart
of this issue.
Thanks,
Alexander.
On 21/09/2017 22:25, Phil Race wrote:
Some procedural comments :
Since 90% of this is in AWT code, I'd have thought awt-dev should be
included here.
I've added that list.
And apart from needing separate bug ids, I don't see why the bug
below is confidential.
I agree with what Kevin pointed out off-line that as in the dialog
case, the FX side
of the code can use reflection and simply be a harmless
non-functional no-op
if the SwingAccessor does not provide the new method.
BTW
264 inline HWND GetOverridenHWnd() { return m_overridenHwnd; }
should be "dd" not "d".
-phil.
On 09/21/2017 03:38 AM, Alexander Zvegintsev wrote:
Hello,
please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/00/
for the issue
https://bugs.openjdk.java.net/browse/JDK-8185634
