Hi Sergey,

The suggested replacing the Swing dialog with the native notification popup seems too radical change for the issue. It might be justified in case of the System LnF, but even in this case I'm not sure, because of possible compatibility problems.

--Semyon


On 09/27/2017 10:07 AM, Sergey Bylokhov wrote:

Hello,
Please review the fix for jdk10.

Bug: https://bugs.openjdk.java.net/browse/JDK-8187639
Webrev can be found at: http://cr.openjdk.java.net/~serb/8187639/webrev.01

Since macOS 10.9(or even early) the main menubar is shown on all screens(not only on the main screen), which means that on both screens the trayIcons are visible. Our code is not ready for this situation, because we create a custom notification window and tries to place it near the trayicon on the main screen.

Instead of updating the logic of showing the window, I migrated the code to the standard notification mechanism which is used in macOS.

Examples:
The old message: http://cr.openjdk.java.net/~serb/8187639/images/Old.png
The new(java -jar): http://cr.openjdk.java.net/~serb/8187639/images/Command%20line.png The new(bundles application): http://cr.openjdk.java.net/~serb/8187639/images/Bundled%20applicateion.png



Reply via email to