On 2018-03-28 01:52, Weijun Wang wrote:

On Mar 24, 2018, at 6:03 AM, Magnus Ihse Bursie <magnus.ihse.bur...@oracle.com> 
wrote:

https://bugs.openjdk.java.net/browse/JDK-8200193 -- for jdk.security.auth
There is only one function to export and it already has JNIEXPORT, so you can 
just remove the new $(LIBJAAS_CFLAGS) [1].
Ok, thanks Max!
Are you going to update your webrev?
Here is a new webrev. It includes your recommended change in Lib-jdk.security.auth.gmk.

It is also updated to keep track of changes in shared native libraries that has happend in the mainline since my first webrev. Most notably is the addition of libjsig. For now, I have just added the JNIEXPORT markers for the platforms that need it. Hopefully we can unify libjsig across all platforms, but that seems to be more complicated than I thought, so that'll have to wait.

I have also recieved word from Phil Race that there were no testing issues for client, so he's happy as well.

Updated webrev: http://cr.openjdk.java.net/~ihse/JDK-8200178-remove-mapfiles/webrev.03

/Magnus


Thanks
Max

[1] 
http://cr.openjdk.java.net/~ihse/JDK-8200178-remove-mapfiles/webrev.01/make/lib/Lib-jdk.security.auth.gmk.sdiff.html

Reply via email to