Looks good. Regards, Manajit
> On 03-Jul-2018, at 1:56 PM, [email protected] wrote: > > Hi Manajit, Thanks for the review and please find the updated webrev: > > http://cr.openjdk.java.net/~sveerabhadra/8195991/webrev.02/ > <http://cr.openjdk.java.net/~sveerabhadra/8195991/webrev.02/> > Thanks and regards, > Shashi > > On 03/07/18 1:25 PM, Manajit Halder wrote: >> Hi Shashi, >> >> BUTTON1_MASK and BUTTON3_MASK are deprecated. >> Remaining code changes looks good. >> >> Regards, >> Manajit >> >>> On 02-Jul-2018, at 9:43 AM, Shashidhara Veerabhadraiah >>> <[email protected] >>> <mailto:[email protected]>> wrote: >>> >>> Thank you Sergey for the review. >>> >>> -Shashi >>> >>> -----Original Message----- >>> From: Sergey Bylokhov >>> Sent: Sunday, July 1, 2018 4:38 AM >>> To: Shashidhara Veerabhadraiah <[email protected] >>> <mailto:[email protected]>>; [email protected] >>> <mailto:[email protected]> >>> Subject: Re: <AWT Dev> [12] JDK-8195991: [TEST_BUG]:Regression manual Test >>> java/awt/TrayIcon/RightClickWhenBalloonDisplayed/RightClickWhenBalloonDisplayed.html >>> fails >>> >>> Looks fine. >>> >>> On 27/06/2018 02:33, Shashidhara Veerabhadraiah wrote: >>>> Hi All, Please find the test bug fix for the below bug: >>>> >>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8195991 >>>> <https://bugs.openjdk.java.net/browse/JDK-8195991> >>>> >>>> Webrev: http://cr.openjdk.java.net/~sveerabhadra/8195991/webrev.01/ >>>> <http://cr.openjdk.java.net/%7Esveerabhadra/8195991/webrev.01/> >>>> >>>> Change details: The test mostly gets stuck on the windows platform >>>> after performing a few steps hence the test modified to perform >>>> seamlessly and along with it, the applet api usage was removed and >>>> have made the test automatic rather than manual one earlier. This test >>>> is moved from closed to open because of the use of the supporting >>>> libraries(ExtendedRobot and SystemTrayIconHelper). >>>> >>>> Thanks and regards, >>>> >>>> Shashi >>>> >>> >>> >>> -- >>> Best regards, Sergey. >> >
