On 30/09/2018 20:48, Krishna Addepalli wrote:
By using static_cast, I have maintained the existing behaviour. I’m not sure
about which function to use, but should we address it separately, or here
itself?
But the existed behavior might maintained without this fix, right? with
one exception that we will need to find all this questionable places
manually, an currently they are highlighted by the compiler.
Thanks,
Krishna
On 01-Oct-2018, at 8:33 AM, Sergey Bylokhov <sergey.bylok...@oracle.com> wrote:
Hi, Krishna.
One initial question about awt_Window.cpp:
2150 w = static_cast<int>((rect.right - rect.left) * scaleX / prevScaleX);
2151 h = static_cast<int>((rect.bottom - rect.top) * scaleY / prevScaleY);
Are you sure that we need to use "cast" instead of ScaleUp/Down?
On 29/09/2018 20:18, Krishna Addepalli wrote:
Hi All,
Please review a fix for JDK-8074824:
https://bugs.openjdk.java.net/browse/JDK-8074824
Webrev: http://cr.openjdk.java.net/~kaddepalli/8074824/webrev01/
<http://cr.openjdk.java.net/%7Ekaddepalli/8074824/webrev01/>
Most of the warnings have been fixed for Linux, Mac and Windows.
Thanks,
Krishna
--
Best regards, Sergey.
--
Best regards, Sergey.
