Re: RFR : 8211317: avoid memory leak in Java_sun_awt_UNIXToolkit_load_1stock_1icon

[Lindenmaier, Goetz]

Hi Matthias,

You can push this now.  There are two Reviewers,
the change sat there more than 24h, and it’s a simple fix.

Thanks, Goetz

From: Langer, Christoph
Sent: Monday, October 8, 2018 10:01 AM
To: Baesken, Matthias <matthias.baes...@sap.com>; Lindenmaier, Goetz 
<goetz.lindenma...@sap.com>; awt-dev@openjdk.java.net
Subject: RE: RFR : 8211317: avoid memory leak in 
Java_sun_awt_UNIXToolkit_load_1stock_1icon

Hi Matthias,

+1

Best regards
Christoph

From: Baesken, Matthias
Sent: Donnerstag, 4. Oktober 2018 09:26
To: Lindenmaier, Goetz 
<goetz.lindenma...@sap.com<mailto:goetz.lindenma...@sap.com>>; 
awt-dev@openjdk.java.net<mailto:awt-dev@openjdk.java.net>
Cc: Langer, Christoph 
<christoph.lan...@sap.com<mailto:christoph.lan...@sap.com>>
Subject: RE: RFR : 8211317: avoid memory leak in 
Java_sun_awt_UNIXToolkit_load_1stock_1icon

Thanks Goetz !

As far as I know a second review is needed  before pushing –  waiting for the 
second review 😉 …


From: Lindenmaier, Goetz
Sent: Donnerstag, 4. Oktober 2018 09:04
To: Baesken, Matthias 
<matthias.baes...@sap.com<mailto:matthias.baes...@sap.com>>; 
awt-dev@openjdk.java.net<mailto:awt-dev@openjdk.java.net>
Cc: Langer, Christoph 
<christoph.lan...@sap.com<mailto:christoph.lan...@sap.com>>
Subject: RE: RFR : 8211317: avoid memory leak in 
Java_sun_awt_UNIXToolkit_load_1stock_1icon

Hi Matthias,

good catch, thanks for fixing this.
Looks good.

Best regards,
  Goetz.


From: Baesken, Matthias
Sent: Donnerstag, 4. Oktober 2018 08:45
To: awt-dev@openjdk.java.net<mailto:awt-dev@openjdk.java.net>
Cc: Lindenmaier, Goetz 
<goetz.lindenma...@sap.com<mailto:goetz.lindenma...@sap.com>>; Langer, 
Christoph <christoph.lan...@sap.com<mailto:christoph.lan...@sap.com>>
Subject: RE: RFR : 8211317: avoid memory leak in 
Java_sun_awt_UNIXToolkit_load_1stock_1icon

Hello could I have a review for this small change ?

Thanks, Matthias

From: Baesken, Matthias
Sent: Montag, 1. Oktober 2018 12:19
To: awt-dev@openjdk.java.net<mailto:awt-dev@openjdk.java.net>
Subject: RFR : 8211317: avoid memory leak in 
Java_sun_awt_UNIXToolkit_load_1stock_1icon

Hello ,  please review this small change .

It adds missing resource – freeing to        
Java_sun_awt_UNIXToolkit_load_1stock_1icon  .


Bug/webrev :

https://bugs.openjdk.java.net/browse/JDK-8211317

http://cr.openjdk.java.net/~mbaesken/webrevs/8211317.0/


Best regards, Matthias